fix(storage): correct allowed file extensions input copy - #3179
Open
cursor[bot] wants to merge 5 commits into
Open
fix(storage): correct allowed file extensions input copy#3179cursor[bot] wants to merge 5 commits into
cursor[bot] wants to merge 5 commits into
Conversation
The bucket settings Allowed file extensions field reused Labels copy (id, label, and placeholder). Use extension-specific wording and clear the placeholder once tags are present so it does not sit beside chips. Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Console (appwrite/console)Project ID: Tip Function builds can take up to 45 minutes before timing out |
Contributor
Greptile SummaryThe PR corrects the allowed-file-extensions field copy and conditionally hides its placeholder after extensions are selected. It also adjusts post-registration routing and broadens the E2E signup helper’s accepted destinations. Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Reviews (5): Last reviewed commit: "fix(auth): navigate after cloud signup s..." | Re-trigger Greptile |
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Cloud register only called goto when a pricing type was present, so CI stayed on /register until waitForURL timed out. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Storage → Bucket → Settings Allowed file extensions field was still using Labels UI copy (
id="user-labels", labelLabels, placeholderSelect or type user labels).This updates the field to extension-specific wording and clears the placeholder once extensions are selected so it does not remain visible next to chips (fixes #1018).
Before and after
Adding suggested extensions (
jpg,png,pdf):Labels, andSelect or type user labelsremains beside the chips.File extensions, the empty placeholder isAllowed file extensions (mp4, jpg, pdf, etc.), and that placeholder is cleared once extensions are selected.Test Plan
Related PRs and Issues